mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 01:58:06 +02:00
Code Activity

Enable the dot-notation ESLint rule

Browse source 
*Please note:* These changes were done automatically, using the `gulp lint --fix` command.

This rule is already enabled in mozilla-central, see https://searchfox.org/mozilla-central/rev/567b68b8ff4b6d607ba34a6f1926873d21a7b4d7/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js#103-104

The main advantage, besides improved consistency, of this rule is that it reduces the size of the code (by 3 bytes for each case). In the PDF.js code-base there's close to 8000 instances being fixed by the `dot-notation` ESLint rule, which end up reducing the size of even the *built* files significantly; the total size of the `gulp mozcentral` build target changes from `3 247 456` to `3 224 278` bytes, which is a *reduction* of `23 178` bytes (or ~0.7%) for a completely mechanical change.

A large number of these changes affect the (large) lookup tables used on the worker-thread, but given that they are still initialized lazily I don't *think* that the new formatting this patch introduces should undo any of the improvements from PR 6915.

Please find additional details about the ESLint rule at https://eslint.org/docs/rules/dot-notation
This commit is contained in:
Jonas Jenwald 2020-04-17 12:06:27 +02:00
parent c218e94f66
commit 1cc3dbb694
26 changed files with 7773 additions and 7785 deletions
Download patch file Download diff file Expand all files Collapse all files

152
src/core/evaluator.js
View file

@ -3533,57 +3533,57 @@ var EvaluatorPreprocessor = (function EvaluatorPreprocessorClosure() {
// If variableArgs === false: exactly `numArgs` expected
var getOPMap = getLookupTableFactory(function (t) {
// Graphic state
t["w"] = { id: OPS.setLineWidth, numArgs: 1, variableArgs: false };
t["J"] = { id: OPS.setLineCap, numArgs: 1, variableArgs: false };
t["j"] = { id: OPS.setLineJoin, numArgs: 1, variableArgs: false };
t["M"] = { id: OPS.setMiterLimit, numArgs: 1, variableArgs: false };
t["d"] = { id: OPS.setDash, numArgs: 2, variableArgs: false };
t["ri"] = { id: OPS.setRenderingIntent, numArgs: 1, variableArgs: false };
t["i"] = { id: OPS.setFlatness, numArgs: 1, variableArgs: false };
t["gs"] = { id: OPS.setGState, numArgs: 1, variableArgs: false };
t["q"] = { id: OPS.save, numArgs: 0, variableArgs: false };
t["Q"] = { id: OPS.restore, numArgs: 0, variableArgs: false };
t["cm"] = { id: OPS.transform, numArgs: 6, variableArgs: false };
t.w = { id: OPS.setLineWidth, numArgs: 1, variableArgs: false };
t.J = { id: OPS.setLineCap, numArgs: 1, variableArgs: false };
t.j = { id: OPS.setLineJoin, numArgs: 1, variableArgs: false };
t.M = { id: OPS.setMiterLimit, numArgs: 1, variableArgs: false };
t.d = { id: OPS.setDash, numArgs: 2, variableArgs: false };
t.ri = { id: OPS.setRenderingIntent, numArgs: 1, variableArgs: false };
t.i = { id: OPS.setFlatness, numArgs: 1, variableArgs: false };
t.gs = { id: OPS.setGState, numArgs: 1, variableArgs: false };
t.q = { id: OPS.save, numArgs: 0, variableArgs: false };
t.Q = { id: OPS.restore, numArgs: 0, variableArgs: false };
t.cm = { id: OPS.transform, numArgs: 6, variableArgs: false };
// Path
t["m"] = { id: OPS.moveTo, numArgs: 2, variableArgs: false };
t["l"] = { id: OPS.lineTo, numArgs: 2, variableArgs: false };
t["c"] = { id: OPS.curveTo, numArgs: 6, variableArgs: false };
t["v"] = { id: OPS.curveTo2, numArgs: 4, variableArgs: false };
t["y"] = { id: OPS.curveTo3, numArgs: 4, variableArgs: false };
t["h"] = { id: OPS.closePath, numArgs: 0, variableArgs: false };
t["re"] = { id: OPS.rectangle, numArgs: 4, variableArgs: false };
t["S"] = { id: OPS.stroke, numArgs: 0, variableArgs: false };
t["s"] = { id: OPS.closeStroke, numArgs: 0, variableArgs: false };
t["f"] = { id: OPS.fill, numArgs: 0, variableArgs: false };
t["F"] = { id: OPS.fill, numArgs: 0, variableArgs: false };
t.m = { id: OPS.moveTo, numArgs: 2, variableArgs: false };
t.l = { id: OPS.lineTo, numArgs: 2, variableArgs: false };
t.c = { id: OPS.curveTo, numArgs: 6, variableArgs: false };
t.v = { id: OPS.curveTo2, numArgs: 4, variableArgs: false };
t.y = { id: OPS.curveTo3, numArgs: 4, variableArgs: false };
t.h = { id: OPS.closePath, numArgs: 0, variableArgs: false };
t.re = { id: OPS.rectangle, numArgs: 4, variableArgs: false };
t.S = { id: OPS.stroke, numArgs: 0, variableArgs: false };
t.s = { id: OPS.closeStroke, numArgs: 0, variableArgs: false };
t.f = { id: OPS.fill, numArgs: 0, variableArgs: false };
t.F = { id: OPS.fill, numArgs: 0, variableArgs: false };
t["f*"] = { id: OPS.eoFill, numArgs: 0, variableArgs: false };
t["B"] = { id: OPS.fillStroke, numArgs: 0, variableArgs: false };
t.B = { id: OPS.fillStroke, numArgs: 0, variableArgs: false };
t["B*"] = { id: OPS.eoFillStroke, numArgs: 0, variableArgs: false };
t["b"] = { id: OPS.closeFillStroke, numArgs: 0, variableArgs: false };
t.b = { id: OPS.closeFillStroke, numArgs: 0, variableArgs: false };
t["b*"] = { id: OPS.closeEOFillStroke, numArgs: 0, variableArgs: false };
t["n"] = { id: OPS.endPath, numArgs: 0, variableArgs: false };
t.n = { id: OPS.endPath, numArgs: 0, variableArgs: false };
// Clipping
t["W"] = { id: OPS.clip, numArgs: 0, variableArgs: false };
t.W = { id: OPS.clip, numArgs: 0, variableArgs: false };
t["W*"] = { id: OPS.eoClip, numArgs: 0, variableArgs: false };
// Text
t["BT"] = { id: OPS.beginText, numArgs: 0, variableArgs: false };
t["ET"] = { id: OPS.endText, numArgs: 0, variableArgs: false };
t["Tc"] = { id: OPS.setCharSpacing, numArgs: 1, variableArgs: false };
t["Tw"] = { id: OPS.setWordSpacing, numArgs: 1, variableArgs: false };
t["Tz"] = { id: OPS.setHScale, numArgs: 1, variableArgs: false };
t["TL"] = { id: OPS.setLeading, numArgs: 1, variableArgs: false };
t["Tf"] = { id: OPS.setFont, numArgs: 2, variableArgs: false };
t["Tr"] = { id: OPS.setTextRenderingMode, numArgs: 1, variableArgs: false };
t["Ts"] = { id: OPS.setTextRise, numArgs: 1, variableArgs: false };
t["Td"] = { id: OPS.moveText, numArgs: 2, variableArgs: false };
t["TD"] = { id: OPS.setLeadingMoveText, numArgs: 2, variableArgs: false };
t["Tm"] = { id: OPS.setTextMatrix, numArgs: 6, variableArgs: false };
t.BT = { id: OPS.beginText, numArgs: 0, variableArgs: false };
t.ET = { id: OPS.endText, numArgs: 0, variableArgs: false };
t.Tc = { id: OPS.setCharSpacing, numArgs: 1, variableArgs: false };
t.Tw = { id: OPS.setWordSpacing, numArgs: 1, variableArgs: false };
t.Tz = { id: OPS.setHScale, numArgs: 1, variableArgs: false };
t.TL = { id: OPS.setLeading, numArgs: 1, variableArgs: false };
t.Tf = { id: OPS.setFont, numArgs: 2, variableArgs: false };
t.Tr = { id: OPS.setTextRenderingMode, numArgs: 1, variableArgs: false };
t.Ts = { id: OPS.setTextRise, numArgs: 1, variableArgs: false };
t.Td = { id: OPS.moveText, numArgs: 2, variableArgs: false };
t.TD = { id: OPS.setLeadingMoveText, numArgs: 2, variableArgs: false };
t.Tm = { id: OPS.setTextMatrix, numArgs: 6, variableArgs: false };
t["T*"] = { id: OPS.nextLine, numArgs: 0, variableArgs: false };
t["Tj"] = { id: OPS.showText, numArgs: 1, variableArgs: false };
t["TJ"] = { id: OPS.showSpacedText, numArgs: 1, variableArgs: false };
t.Tj = { id: OPS.showText, numArgs: 1, variableArgs: false };
t.TJ = { id: OPS.showSpacedText, numArgs: 1, variableArgs: false };
t["'"] = { id: OPS.nextLineShowText, numArgs: 1, variableArgs: false };
t['"'] = {
id: OPS.nextLineSetSpacingShowText,
@ -3592,62 +3592,62 @@ var EvaluatorPreprocessor = (function EvaluatorPreprocessorClosure() {
};
// Type3 fonts
t["d0"] = { id: OPS.setCharWidth, numArgs: 2, variableArgs: false };
t["d1"] = {
t.d0 = { id: OPS.setCharWidth, numArgs: 2, variableArgs: false };
t.d1 = {
id: OPS.setCharWidthAndBounds,
numArgs: 6,
variableArgs: false,
};
// Color
t["CS"] = { id: OPS.setStrokeColorSpace, numArgs: 1, variableArgs: false };
t["cs"] = { id: OPS.setFillColorSpace, numArgs: 1, variableArgs: false };
t["SC"] = { id: OPS.setStrokeColor, numArgs: 4, variableArgs: true };
t["SCN"] = { id: OPS.setStrokeColorN, numArgs: 33, variableArgs: true };
t["sc"] = { id: OPS.setFillColor, numArgs: 4, variableArgs: true };
t["scn"] = { id: OPS.setFillColorN, numArgs: 33, variableArgs: true };
t["G"] = { id: OPS.setStrokeGray, numArgs: 1, variableArgs: false };
t["g"] = { id: OPS.setFillGray, numArgs: 1, variableArgs: false };
t["RG"] = { id: OPS.setStrokeRGBColor, numArgs: 3, variableArgs: false };
t["rg"] = { id: OPS.setFillRGBColor, numArgs: 3, variableArgs: false };
t["K"] = { id: OPS.setStrokeCMYKColor, numArgs: 4, variableArgs: false };
t["k"] = { id: OPS.setFillCMYKColor, numArgs: 4, variableArgs: false };
t.CS = { id: OPS.setStrokeColorSpace, numArgs: 1, variableArgs: false };
t.cs = { id: OPS.setFillColorSpace, numArgs: 1, variableArgs: false };
t.SC = { id: OPS.setStrokeColor, numArgs: 4, variableArgs: true };
t.SCN = { id: OPS.setStrokeColorN, numArgs: 33, variableArgs: true };
t.sc = { id: OPS.setFillColor, numArgs: 4, variableArgs: true };
t.scn = { id: OPS.setFillColorN, numArgs: 33, variableArgs: true };
t.G = { id: OPS.setStrokeGray, numArgs: 1, variableArgs: false };
t.g = { id: OPS.setFillGray, numArgs: 1, variableArgs: false };
t.RG = { id: OPS.setStrokeRGBColor, numArgs: 3, variableArgs: false };
t.rg = { id: OPS.setFillRGBColor, numArgs: 3, variableArgs: false };
t.K = { id: OPS.setStrokeCMYKColor, numArgs: 4, variableArgs: false };
t.k = { id: OPS.setFillCMYKColor, numArgs: 4, variableArgs: false };
// Shading
t["sh"] = { id: OPS.shadingFill, numArgs: 1, variableArgs: false };
t.sh = { id: OPS.shadingFill, numArgs: 1, variableArgs: false };
// Images
t["BI"] = { id: OPS.beginInlineImage, numArgs: 0, variableArgs: false };
t["ID"] = { id: OPS.beginImageData, numArgs: 0, variableArgs: false };
t["EI"] = { id: OPS.endInlineImage, numArgs: 1, variableArgs: false };
t.BI = { id: OPS.beginInlineImage, numArgs: 0, variableArgs: false };
t.ID = { id: OPS.beginImageData, numArgs: 0, variableArgs: false };
t.EI = { id: OPS.endInlineImage, numArgs: 1, variableArgs: false };
// XObjects
t["Do"] = { id: OPS.paintXObject, numArgs: 1, variableArgs: false };
t["MP"] = { id: OPS.markPoint, numArgs: 1, variableArgs: false };
t["DP"] = { id: OPS.markPointProps, numArgs: 2, variableArgs: false };
t["BMC"] = { id: OPS.beginMarkedContent, numArgs: 1, variableArgs: false };
t["BDC"] = {
t.Do = { id: OPS.paintXObject, numArgs: 1, variableArgs: false };
t.MP = { id: OPS.markPoint, numArgs: 1, variableArgs: false };
t.DP = { id: OPS.markPointProps, numArgs: 2, variableArgs: false };
t.BMC = { id: OPS.beginMarkedContent, numArgs: 1, variableArgs: false };
t.BDC = {
id: OPS.beginMarkedContentProps,
numArgs: 2,
variableArgs: false,
};
t["EMC"] = { id: OPS.endMarkedContent, numArgs: 0, variableArgs: false };
t.EMC = { id: OPS.endMarkedContent, numArgs: 0, variableArgs: false };
// Compatibility
t["BX"] = { id: OPS.beginCompat, numArgs: 0, variableArgs: false };
t["EX"] = { id: OPS.endCompat, numArgs: 0, variableArgs: false };
t.BX = { id: OPS.beginCompat, numArgs: 0, variableArgs: false };
t.EX = { id: OPS.endCompat, numArgs: 0, variableArgs: false };
// (reserved partial commands for the lexer)
t["BM"] = null;
t["BD"] = null;
t["true"] = null;
t["fa"] = null;
t["fal"] = null;
t["fals"] = null;
t["false"] = null;
t["nu"] = null;
t["nul"] = null;
t["null"] = null;
t.BM = null;
t.BD = null;
t.true = null;
t.fa = null;
t.fal = null;
t.fals = null;
t.false = null;
t.nu = null;
t.nul = null;
t.null = null;
});
const MAX_INVALID_PATH_OPS = 20;