mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-23 16:48:08 +02:00
Code Activity

Change PDFDocument.prototype._xfaStreams to return a Map

Browse source 
Using a `Map` rather than an `Object` is a nicer, since it has better support for both iteration and checking if a key exists.
We also change the initial values to be `null`, rather than empty strings, and reduce duplication when creating the `Map`.

*Please note:* Since this is worker-thread code, these changes are "invisible" at the API-level.
This commit is contained in:
Jonas Jenwald 2025-04-12 12:36:09 +02:00
parent 9c6e2e6df0
commit 1c80412f61
1 changed files with 18 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

34
src/core/document.js
View file

@ -1117,24 +1117,26 @@ class PDFDocument {
}
get _xfaStreams() {
const acroForm = this.catalog.acroForm;
const { acroForm } = this.catalog;
if (!acroForm) {
return null;
}
const xfa = acroForm.get("XFA");
const entries = {
"xdp:xdp": "",
template: "",
datasets: "",
config: "",
connectionSet: "",
localeSet: "",
stylesheet: "",
"/xdp:xdp": "",
};
const entries = new Map(
[
"xdp:xdp",
"template",
"datasets",
"config",
"connectionSet",
"localeSet",
"stylesheet",
"/xdp:xdp",
].map(e => [e, null])
);
if (xfa instanceof BaseStream && !xfa.isEmpty) {
entries["xdp:xdp"] = xfa;
entries.set("xdp:xdp", xfa);
return entries;
}
@ -1152,14 +1154,14 @@ class PDFDocument {
name = xfa[i];
}
if (!entries.hasOwnProperty(name)) {
if (!entries.has(name)) {
continue;
}
const data = this.xref.fetchIfRef(xfa[i + 1]);
if (!(data instanceof BaseStream) || data.isEmpty) {
continue;
}
entries[name] = data;
entries.set(name, data);
}
return entries;
}
@ -1170,7 +1172,7 @@ class PDFDocument {
return shadow(this, "xfaDatasets", null);
}
for (const key of ["datasets", "xdp:xdp"]) {
const stream = streams[key];
const stream = streams.get(key);
if (!stream) {
continue;
}
@ -1192,7 +1194,7 @@ class PDFDocument {
return null;
}
const data = Object.create(null);
for (const [key, stream] of Object.entries(streams)) {
for (const [key, stream] of streams) {
if (!stream) {
continue;
}