mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 14:48:08 +02:00
Code Activity

Merge pull request #15970 from calixteman/editor_invisible

Browse source 
[Editor] Make the annotation editor layer invisible when disabled and empty
This commit is contained in:
calixteman 2023-02-01 21:25:32 +01:00 • committed by GitHub
commit 1bdee0b59b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/display/editor/annotation_editor_layer.js
View file

@ -84,6 +84,10 @@ class AnnotationEditorLayer {
this.#uiManager.addLayer(this);
}
get isEmpty() {
return this.#editors.size === 0;
}
/**
* Update the toolbar if it's required to reflect the tool currently used.
* @param {number} mode
@ -107,11 +111,17 @@ class AnnotationEditorLayer {
}
this.#uiManager.unselectAll();
this.div.classList.toggle(
"freeTextEditing",
mode === AnnotationEditorType.FREETEXT
);
this.div.classList.toggle("inkEditing", mode === AnnotationEditorType.INK);
if (mode !== AnnotationEditorType.NONE) {
this.div.classList.toggle(
"freeTextEditing",
mode === AnnotationEditorType.FREETEXT
);
this.div.classList.toggle(
"inkEditing",
mode === AnnotationEditorType.INK
);
this.div.hidden = false;
}
}
addInkEditorIfNeeded(isCommitting) {
@ -172,6 +182,10 @@ class AnnotationEditorLayer {
for (const editor of this.#editors.values()) {
editor.disableEditing();
}
this.#cleanup();
if (this.isEmpty) {
this.div.hidden = true;
}
}
/**

4
web/annotation_editor_layer_builder.js
View file

@ -75,6 +75,7 @@ class AnnotationEditorLayerBuilder {
const div = (this.div = document.createElement("div"));
div.className = "annotationEditorLayer";
div.tabIndex = 0;
div.hidden = true;
this.pageDiv.append(div);
this.annotationEditorLayer = new AnnotationEditorLayer({
@ -94,6 +95,7 @@ class AnnotationEditorLayerBuilder {
};
this.annotationEditorLayer.render(parameters);
this.show();
}
cancel() {
@ -115,7 +117,7 @@ class AnnotationEditorLayerBuilder {
}
show() {
if (!this.div) {
if (!this.div || this.annotationEditorLayer.isEmpty) {
return;
}
this.div.hidden = false;