mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

Enable the consistent-return ESLint rule

Browse source 
This rule is already enabled in mozilla-central, and helps ensure more consistent functions/methods, see https://searchfox.org/mozilla-central/rev/b9da45f63cb567244933c77b2c7e827a057d3f9b/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js#119-120

Please see https://eslint.org/docs/rules/consistent-return for additional information.
This commit is contained in:
Jonas Jenwald 2019-05-10 12:54:06 +02:00
parent ca2fee3d51
commit 173fbef05b
26 changed files with 105 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/test.js
View file

@ -296,10 +296,11 @@ function getTestManifest() {
testFilter.splice(i, 1);
return true;
}
return false;
});
if (testFilter.length) {
console.error('Unrecognized test IDs: ' + testFilter.join(' '));
return;
return undefined;
}
}
return manifest;

4
test/unit/fetch_stream_spec.js
View file

@ -39,7 +39,7 @@ describe('fetch_stream', function() {
const read = function() {
return fullReader.read().then(function(result) {
if (result.done) {
return;
return undefined;
}
len += result.value.byteLength;
@ -85,7 +85,7 @@ describe('fetch_stream', function() {
const read = function(reader, lenResult) {
return reader.read().then(function(result) {
if (result.done) {
return;
return undefined;
}
lenResult.value += result.value.byteLength;

4
test/unit/network_spec.js
View file

@ -39,7 +39,7 @@ describe('network', function() {
var read = function () {
return fullReader.read().then(function (result) {
if (result.done) {
return;
return undefined;
}
count++;
len += result.value.byteLength;
@ -94,7 +94,7 @@ describe('network', function() {
var read = function (reader, lenResult) {
return reader.read().then(function (result) {
if (result.done) {
return;
return undefined;
}
lenResult.value += result.value.byteLength;
return read(reader, lenResult);

25
test/unit/network_utils_spec.js
View file

@ -37,6 +37,7 @@ describe('network_utils', function() {
if (headerName === 'Content-Length') {
return 8;
}
throw new Error(`Unexpected headerName: ${headerName}`);
},
rangeChunkSize: 64,
})).toEqual({
@ -51,6 +52,7 @@ describe('network_utils', function() {
if (headerName === 'Content-Length') {
return 8;
}
throw new Error(`Unexpected headerName: ${headerName}`);
},
rangeChunkSize: 64,
})).toEqual({
@ -69,6 +71,7 @@ describe('network_utils', function() {
} else if (headerName === 'Content-Length') {
return 8;
}
throw new Error(`Unexpected headerName: ${headerName}`);
},
rangeChunkSize: 64,
})).toEqual({
@ -89,6 +92,7 @@ describe('network_utils', function() {
} else if (headerName === 'Content-Length') {
return 8;
}
throw new Error(`Unexpected headerName: ${headerName}`);
},
rangeChunkSize: 64,
})).toEqual({
@ -109,6 +113,7 @@ describe('network_utils', function() {
} else if (headerName === 'Content-Length') {
return 'eight';
}
throw new Error(`Unexpected headerName: ${headerName}`);
},
rangeChunkSize: 64,
})).toEqual({
@ -129,6 +134,7 @@ describe('network_utils', function() {
} else if (headerName === 'Content-Length') {
return 8;
}
throw new Error(`Unexpected headerName: ${headerName}`);
},
rangeChunkSize: 64,
})).toEqual({
@ -149,6 +155,7 @@ describe('network_utils', function() {
} else if (headerName === 'Content-Length') {
return 8192;
}
throw new Error(`Unexpected headerName: ${headerName}`);
},
rangeChunkSize: 64,
})).toEqual({
@ -164,18 +171,21 @@ describe('network_utils', function() {
if (headerName === 'Content-Disposition') {
return null;
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toBeNull();
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return undefined;
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toBeNull();
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return '';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toBeNull();
});
@ -184,42 +194,49 @@ describe('network_utils', function() {
if (headerName === 'Content-Disposition') {
return 'inline';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toBeNull();
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toBeNull();
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment; filename="filename.pdf"';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf');
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment; filename="filename.pdf and spaces.pdf"';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf and spaces.pdf');
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment; filename="tl;dr.pdf"';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('tl;dr.pdf');
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment; filename=filename.pdf';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf');
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment; filename=filename.pdf someotherparam';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf');
});
@ -228,30 +245,35 @@ describe('network_utils', function() {
if (headerName === 'Content-Disposition') {
return 'attachment; filename*=filename.pdf';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf');
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment; filename*=\'\'filename.pdf';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf');
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment; filename*=utf-8\'\'filename.pdf';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf');
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment; filename=no.pdf; filename*=utf-8\'\'filename.pdf';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf');
expect(extractFilenameFromHeader((headerName) => {
if (headerName === 'Content-Disposition') {
return 'attachment; filename*=utf-8\'\'filename.pdf; filename=no.pdf';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf');
});
@ -261,6 +283,7 @@ describe('network_utils', function() {
if (headerName === 'Content-Disposition') {
return 'attachment; filename*0=filename; filename*1=.pdf';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('filename.pdf');
});
@ -269,6 +292,7 @@ describe('network_utils', function() {
if (headerName === 'Content-Disposition') {
return 'attachment; filename="filename.png"';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toBeNull();
});
@ -277,6 +301,7 @@ describe('network_utils', function() {
if (headerName === 'Content-Disposition') {
return 'form-data; name="fieldName"; filename="file.PdF"';
}
throw new Error(`Unexpected headerName: ${headerName}`);
})).toEqual('file.PdF');
});
});

6
test/unit/node_stream_spec.js
View file

@ -109,7 +109,7 @@ describe('node_stream', function() {
let read1 = function () {
return fullReader1.read().then(function (result) {
if (result.done) {
return;
return undefined;
}
len1 += result.value.byteLength;
return read1();
@ -118,7 +118,7 @@ describe('node_stream', function() {
let read2 = function () {
return fullReader2.read().then(function (result) {
if (result.done) {
return;
return undefined;
}
len2 += result.value.byteLength;
return read2();
@ -195,7 +195,7 @@ describe('node_stream', function() {
let read = function (reader, lenResult) {
return reader.read().then(function (result) {
if (result.done) {
return;
return undefined;
}
lenResult.value += result.value.byteLength;
return read(reader, lenResult);