1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 10:08:06 +02:00

Enable the consistent-return ESLint rule

This rule is already enabled in mozilla-central, and helps ensure more consistent functions/methods, see https://searchfox.org/mozilla-central/rev/b9da45f63cb567244933c77b2c7e827a057d3f9b/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js#119-120

Please see https://eslint.org/docs/rules/consistent-return for additional information.
This commit is contained in:
Jonas Jenwald 2019-05-10 12:54:06 +02:00
parent ca2fee3d51
commit 173fbef05b
26 changed files with 105 additions and 55 deletions

View file

@ -302,12 +302,12 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
if (!(w && isNum(w)) || !(h && isNum(h))) {
warn('Image dimensions are missing, or not numbers.');
return;
return undefined;
}
var maxImageSize = this.options.maxImageSize;
if (maxImageSize !== -1 && w * h > maxImageSize) {
warn('Image exceeded maximum allowed size and was removed.');
return;
return undefined;
}
var imageMask = (dict.get('ImageMask', 'IM') || false);
@ -343,7 +343,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
args,
};
}
return;
return undefined;
}
var softMask = (dict.get('SMask', 'SM') || false);
@ -364,7 +364,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
// any other kind.
imgData = imageObj.createImageData(/* forceRGBA = */ true);
operatorList.addOp(OPS.paintInlineImageXObject, [imgData]);
return;
return undefined;
}
const nativeImageDecoderSupport = forceDisableNativeImageDecoder ?
@ -452,6 +452,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
}
this.handler.send('obj', [objId, this.pageIndex, 'Image', imgData],
[imgData.data.buffer]);
return undefined;
}).catch((reason) => {
warn('Unable to decode image: ' + reason);
@ -460,6 +461,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
[objId, 'FontType3Res', null]);
}
this.handler.send('obj', [objId, this.pageIndex, 'Image', null]);
return undefined;
});
if (this.parsingType3Font) {
@ -476,6 +478,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
args,
};
}
return undefined;
},
handleSMask: function PartialEvaluator_handleSmask(smask, resources,