mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-23 08:38:06 +02:00
Code Activity

Define a few editor event handler functions inline

Browse source 
Given that we're removing event listeners with `AbortSignal` it's no longer necessary to keep a reference to a few of the event handler functions in order to remove them.
Hence we can simply inline the relevant `bind`-calls instead, which reduces the code-size a tiny bit.
This commit is contained in:
Jonas Jenwald 2024-08-05 12:22:38 +02:00
parent 829c9f553d
commit 0eac5e9d6f
2 changed files with 14 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/display/editor/highlight.js
View file

@ -53,8 +53,6 @@ class HighlightEditor extends AnnotationEditor {
#isFreeHighlight = false;
#boundKeydown = this.#keydown.bind(this);
#lastPoint = null;
#opacity;
@ -568,7 +566,7 @@ class HighlightEditor extends AnnotationEditor {
if (this.#isFreeHighlight) {
div.classList.add("free");
} else {
this.div.addEventListener("keydown", this.#boundKeydown, {
this.div.addEventListener("keydown", this.#keydown.bind(this), {
signal: this._uiManager._signal,
});
}

28
src/display/editor/tools.js
View file

@ -612,16 +612,6 @@ class AnnotationEditorUIManager {
#boundKeyup = this.keyup.bind(this);
#boundOnEditingAction = this.onEditingAction.bind(this);
#boundOnPageChanging = this.onPageChanging.bind(this);
#boundOnScaleChanging = this.onScaleChanging.bind(this);
#boundOnSetPreference = this.onSetPreference.bind(this);
#boundOnRotationChanging = this.onRotationChanging.bind(this);
#previousStates = {
isEditing: false,
isEmpty: true,
@ -794,13 +784,21 @@ class AnnotationEditorUIManager {
this.#viewer = viewer;
this.#altTextManager = altTextManager;
this._eventBus = eventBus;
this._eventBus._on("editingaction", this.#boundOnEditingAction, { signal });
this._eventBus._on("pagechanging", this.#boundOnPageChanging, { signal });
this._eventBus._on("scalechanging", this.#boundOnScaleChanging, { signal });
this._eventBus._on("rotationchanging", this.#boundOnRotationChanging, {
this._eventBus._on("editingaction", this.onEditingAction.bind(this), {
signal,
});
this._eventBus._on("pagechanging", this.onPageChanging.bind(this), {
signal,
});
this._eventBus._on("scalechanging", this.onScaleChanging.bind(this), {
signal,
});
this._eventBus._on("rotationchanging", this.onRotationChanging.bind(this), {
signal,
});
this._eventBus._on("setpreference", this.onSetPreference.bind(this), {
signal,
});
this._eventBus._on("setpreference", this.#boundOnSetPreference, { signal });
this.#addSelectionListener();
this.#addDragAndDropListeners();
this.#addKeyboardManager();