mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 14:48:08 +02:00
Code Activity

Fix the "must check that a field has the correct value when a choice is changed" scripting integration test

Browse source 
We should not wait for an arbitrary amount of time, which can easily
cause intermittent failures, but wait for a value change instead. Note
that this patch mirrors the approach we already use in other scripting
integration tests that also check for a value change; see e.g. the
"must check that a field has the correct formatted value" test.
This commit is contained in:
Tim van der Meij 2024-04-15 15:55:28 +02:00
parent 00af2e7b7a
commit 0e612fbb7d
No known key found for this signature in database
GPG key ID: 8C3FD2925A5F2762
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/integration/scripting_spec.mjs
View file

@ -1932,18 +1932,14 @@ describe("Interaction", () => {
expect(text).withContext(`In ${browserName}`).toEqual("");
await page.select(getSelector("6R"), "Yes");
// eslint-disable-next-line no-restricted-syntax
await waitForTimeout(10);
await page.waitForFunction(`${getQuerySelector("44R")}.value !== ""`);
text = await page.$eval(getSelector("44R"), el => el.value);
expect(text).withContext(`In ${browserName}`).toEqual("Yes");
await clearInput(page, getSelector("44R"));
await page.select(getSelector("6R"), "No");
// eslint-disable-next-line no-restricted-syntax
await waitForTimeout(10);
await page.waitForFunction(`${getQuerySelector("44R")}.value !== ""`);
text = await page.$eval(getSelector("44R"), el => el.value);
expect(text).withContext(`In ${browserName}`).toEqual("No");
})