From 92adc7ea1b8d3e185c13b396c7c8799e5269b15f Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Wed, 12 Mar 2025 14:50:27 +0100 Subject: [PATCH] Don't shadow the `TouchManager.prototype.MIN_TOUCH_DISTANCE_TO_PINCH` value The `devicePixelRatio` may change if the window resolution changes, which can happen e.g. if the viewer is moved to another monitor. --- src/display/touch_manager.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/display/touch_manager.js b/src/display/touch_manager.js index 69f6a9f6d..c570195b5 100644 --- a/src/display/touch_manager.js +++ b/src/display/touch_manager.js @@ -13,7 +13,6 @@ * limitations under the License. */ -import { shadow } from "../shared/util.js"; import { stopEvent } from "./display_utils.js"; class TouchManager { @@ -65,6 +64,10 @@ class TouchManager { }); } + /** + * NOTE: Don't shadow this value since `devicePixelRatio` may change if the + * window resolution changes, e.g. if the viewer is moved to another monitor. + */ get MIN_TOUCH_DISTANCE_TO_PINCH() { // The 35 is coming from: // https://searchfox.org/mozilla-central/source/gfx/layers/apz/src/GestureEventListener.cpp#36 @@ -72,11 +75,7 @@ class TouchManager { // The properties TouchEvent::screenX/Y are in screen CSS pixels: // https://developer.mozilla.org/en-US/docs/Web/API/Touch/screenX#examples // MIN_TOUCH_DISTANCE_TO_PINCH is in CSS pixels. - return shadow( - this, - "MIN_TOUCH_DISTANCE_TO_PINCH", - 35 / (window.devicePixelRatio || 1) - ); + return 35 / (window.devicePixelRatio || 1); } #onTouchStart(evt) {