mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

Support FileAttachments with hash-signs in the filename (issue 15729)

Browse source 
The reason for the issue is that we use the generic `getFilenameFromUrl` helper function, which was originally intended for regular URLs.
For the filenames we're dealing with in FileAttachments, we really only want to strip the path when one exists[1].

---
[1] See [bug 1230933](https://bugzilla.mozilla.org/show_bug.cgi?id=1230933) for an example of such a case.
This commit is contained in:
Jonas Jenwald 2022-11-23 10:40:30 +01:00
parent a0db81723b
commit 0ba242ea4a
4 changed files with 20 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
test/unit/display_utils_spec.js
View file

@ -190,6 +190,13 @@ describe("display_utils", function () {
const url = "https://server.org/filename.pdf?foo=bar";
expect(getFilenameFromUrl(url)).toEqual("filename.pdf");
});
it("should get the filename from a relative URL, keeping the anchor", function () {
const url = "../../part1#part2.pdf";
expect(getFilenameFromUrl(url, /* onlyStripPath = */ true)).toEqual(
"part1#part2.pdf"
);
});
});
describe("getPdfFilenameFromUrl", function () {