mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-18 14:18:23 +02:00
Code Activity

Use Array-destructuring when computing MIN/MAX in AFSimple_Calculate

Browse source 
This appears to work fine with QuickJS, as evident by the added unit-test, and allows us to remove more `Array.prototype.reduce` usage.
This commit is contained in:
Jonas Jenwald 2025-04-06 11:44:08 +02:00
parent 6cc37c8415
commit 0845552ff9
2 changed files with 112 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/scripting_api/aform.js
View file

@ -392,10 +392,8 @@ class AForm {
AVG: args => args.reduce((acc, value) => acc + value, 0) / args.length,
SUM: args => args.reduce((acc, value) => acc + value, 0),
PRD: args => args.reduce((acc, value) => acc * value, 1),
MIN: args =>
args.reduce((acc, value) => Math.min(acc, value), Number.MAX_VALUE),
MAX: args =>
args.reduce((acc, value) => Math.max(acc, value), Number.MIN_VALUE),
MIN: args => Math.min(...args),
MAX: args => Math.max(...args),
};
if (!(cFunction in actions)) {

110
test/unit/scripting_spec.js
View file

@ -1394,6 +1394,116 @@ describe("Scripting", function () {
formattedValue: null,
});
});
it("should compute the max of several fields", async () => {
const refIds = [0, 1, 2, 3, 4].map(_ => getId());
const data = {
objects: {
field1: [
{
id: refIds[0],
value: "",
actions: {},
type: "text",
},
],
field2: [
{
id: refIds[1],
value: "",
actions: {},
type: "text",
},
],
field3: [
{
id: refIds[2],
value: "",
actions: {},
type: "text",
},
],
field4: [
{
id: refIds[3],
value: "",
actions: {
Calculate: [
`AFSimple_Calculate("MAX", ["field1", "field2", "field3", "unknown"]);`,
],
},
type: "text",
},
],
field5: [
{
id: refIds[4],
value: "",
actions: {
Calculate: [
`AFSimple_Calculate("MAX", "field1, field2, field3, unknown");`,
],
},
type: "text",
},
],
},
appInfo: { language: "en-US", platform: "Linux x86_64" },
calculationOrder: [refIds[3], refIds[4]],
dispatchEventName: "_dispatchMe",
};
sandbox.createSandbox(data);
await sandbox.dispatchEventInSandbox({
id: refIds[0],
value: "1",
name: "Keystroke",
willCommit: true,
});
expect(send_queue.has(refIds[3])).toEqual(true);
expect(send_queue.get(refIds[3])).toEqual({
id: refIds[3],
siblings: null,
value: 1,
formattedValue: null,
});
await sandbox.dispatchEventInSandbox({
id: refIds[1],
value: "2",
name: "Keystroke",
willCommit: true,
});
expect(send_queue.has(refIds[3])).toEqual(true);
expect(send_queue.get(refIds[3])).toEqual({
id: refIds[3],
siblings: null,
value: 2,
formattedValue: null,
});
await sandbox.dispatchEventInSandbox({
id: refIds[2],
value: "3",
name: "Keystroke",
willCommit: true,
});
expect(send_queue.has(refIds[3])).toEqual(true);
expect(send_queue.get(refIds[3])).toEqual({
id: refIds[3],
siblings: null,
value: 3,
formattedValue: null,
});
expect(send_queue.has(refIds[4])).toEqual(true);
expect(send_queue.get(refIds[4])).toEqual({
id: refIds[4],
siblings: null,
value: 3,
formattedValue: null,
});
});
});
describe("AFSpecial_KeystrokeEx", function () {