Replace element ids with custom attributes for Widget-annotations (issue 15056)

Browse source

We want to avoid adding regular `id`s to Annotation-elements, since that means that they become "linkable" through the URL hash in a way that's not supported/intended. This could end up clashing with "named destinations", and that could easily lead to bugs; see issue 11499 and PR 11503 for some context.

Rather than using `id`s, we'll instead use a *custom* `data-element-id` attribute such that it's still possible to access the Annotation-elements directly.
Unfortunately these changes required updating most of the integration-tests, and to reduce the amount of repeated code a couple of helper functions were added.

...

This commit is contained in:

Jonas Jenwald 2022-06-17 22:01:20 +02:00

parent 3ca8d2c4f9

commit 03757d82b7

5 changed files with 425 additions and 384 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

655

test/integration/scripting_spec.js

View file

File diff suppressed because it is too large Load diff