From 033d27fc25342f309fc208b0f8cc555bc78cdeaa Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 19 Apr 2020 10:29:26 +0200 Subject: [PATCH] [src/core/fonts.js] Replace some unnecessary `Stream.getUint16()` calls with `Stream.skip(2)` instead There's a handful of cases in the code where the intention is simply to advance the `Stream` position, but rather than only doing that the code instead fetches/computes a Uint16 value (and without using the result for anything). --- src/core/fonts.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/core/fonts.js b/src/core/fonts.js index 6e22b9e14..73f82ac18 100644 --- a/src/core/fonts.js +++ b/src/core/fonts.js @@ -1590,7 +1590,7 @@ var Font = (function FontClosure() { var start = (file.start ? file.start : 0) + cmap.offset; file.pos = start; - file.getUint16(); // version + file.skip(2); // version var numTables = file.getUint16(); var potentialTable; @@ -1665,8 +1665,7 @@ var Font = (function FontClosure() { } var format = file.getUint16(); - file.getUint16(); // length - file.getUint16(); // language + file.skip(2 + 2); // length + language var hasShortCmap = false; var mappings = []; @@ -1695,7 +1694,7 @@ var Font = (function FontClosure() { for (segIndex = 0; segIndex < segCount; segIndex++) { segments.push({ end: file.getUint16() }); } - file.getUint16(); + file.skip(2); for (segIndex = 0; segIndex < segCount; segIndex++) { segments[segIndex].start = file.getUint16(); }