Add the new ENABLE flags for LDAP and SAML

CHANGELOG.md

@@ -4,6 +4,13 @@
 ### Added
 - `bin/upgrade` displays any changes to the changelog and prompts for
    confirmation before applying the remote changes to the local branch.
+   
+### Changed
+- Breaking change!!! LDAP and SAML features are now activated by two new
+  variables: `SHARELATEX_LDAP_ENABLE` and `SHARELATEX_SAML_ENABLE`.
+  These features will be inactive unless the appropriate line is added
+  to `config/variables.env` -- `SHARELATEX_LDAP_ENABLE=true` or
+  `SHARELATEX_SAML_ENABLE=true`
 
 ### Misc
 - Fix code linting errors in bin/ scripts

doc/ldap.md

@@ -17,6 +17,7 @@ At Overleaf, we test the LDAP integration against a [test openldap server](https
 ```
 # added to variables.env
 
+SHARELATEX_LDAP_ENABLE=true
 SHARELATEX_LDAP_URL=ldap://ldap:389
 SHARELATEX_LDAP_SEARCH_BASE=ou=people,dc=planetexpress,dc=com
 SHARELATEX_LDAP_SEARCH_FILTER=(uid={{username}})

doc/saml.md

@@ -13,6 +13,7 @@ At Overleaf, we test the SAML integration against a SAML test server. The follow
 ```
 # added to variables.env
 
+SHARELATEX_SAML_ENABLE=true
 SHARELATEX_SAML_ENTRYPOINT=http://localhost:8081/simplesaml/saml2/idp/SSOService.php
 SHARELATEX_SAML_CALLBACK_URL=http://saml/saml/callback
 SHARELATEX_SAML_ISSUER=sharelatex-test-saml

lib/config-seed/variables.env

@@ -48,6 +48,7 @@ TEXMFVAR=/var/lib/sharelatex/tmp/texmf-var
 ## Server Pro ##
 ################
 
+# SHARELATEX_LDAP_ENABLE=true
 # SHARELATEX_LDAP_URL=ldap://ldap:389
 # SHARELATEX_LDAP_SEARCH_BASE=ou=people,dc=planetexpress,dc=com
 # SHARELATEX_LDAP_SEARCH_FILTER=(uid={{username}})