1
0
Fork 0
mirror of https://github.com/overleaf/toolkit.git synced 2025-04-19 15:28:06 +02:00

Merge pull request #265 from overleaf/jpa-dc-v1-deprecation

Add deprecation warning for usage of docker-compose v1
This commit is contained in:
Jakob Ackermann 2024-06-24 09:57:36 +02:00 committed by GitHub
commit 5e6ee8ff5d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 0 deletions

View file

@ -1,5 +1,13 @@
# Changelog
## 2024-06-21
### Added
- Added warning for usage of legacy docker-compose v1.
docker-compose v1 has reached its End Of Life in July 2023 (https://docs.docker.com/compose/migrate/).
Support for docker-compose v1 in the Overleaf Toolkit will be dropped with the release of Server Pro 5.2.
We recommend upgrading to Docker Compose v2 before then.
## 2024-06-20
### Added
- Updated default [`version`](https://github.com/overleaf/toolkit/blob/master/lib/config-seed/version) to `5.0.6`.

View file

@ -199,6 +199,7 @@ function docker_compose() {
exec docker compose "${flags[@]}"
elif command -v docker-compose >/dev/null; then
# Fall back to docker-compose v1
echo "WARNING: docker-compose v1 has reached its End Of Life in July 2023 (https://docs.docker.com/compose/migrate/). Support for docker-compose v1 in the Overleaf Toolkit will be dropped with the release of Server Pro 5.2. We recommend upgrading to Docker Compose v2 before then." >&2
exec docker-compose "${flags[@]}"
else
echo "ERROR: Could not find Docker Compose." >&2

View file

@ -130,6 +130,7 @@ function check_dependencies() {
print_point 2 "status: present"
print_point 2 "version info: $(docker compose version)"
elif command -v docker-compose > /dev/null; then
add_warning "docker-compose v1 has reached its End Of Life in July 2023 (https://docs.docker.com/compose/migrate/). Support for docker-compose v1 in the Overleaf Toolkit will be dropped with the release of Server Pro 5.2. We recommend upgrading to Docker Compose v2 before then."
check_for_binary docker-compose
else
add_warning "Docker Compose not found"