c2071c0e14
Enhanced Dockerfile snippet in README.md
The Dockerfile snippet in the README.md file required adjustments to align it more closely with the actual Dockerfiles in both the Backend and Frontend directories. I've made a few improvements to ensure clarity and accuracy.
Original Snippet in Repository:
FROM node:13.13.0-stretch-slim
# Argument passed from docker-compose.yaml file
ARG NODE_PORT
# Echo the argument to check if it's loaded correctly
RUN echo "Argument port is: $NODE_PORT"
# Create app directory
WORKDIR /usr/src/app
# Copy entire content
COPY . .
# Install app dependencies
RUN npm install
# My app binds to port NODE_PORT; use the EXPOSE instruction for Docker daemon mapping:
EXPOSE ${NODE_PORT}
CMD npm run dev
Modified Snippet:
FROM node:13.13.0-stretch-slim
# Argument passed from docker-compose.yaml file
ARG NODE_PORT
# Echo the argument to check if it's loaded correctly
RUN echo "Argument port is: $NODE_PORT"
# Create app directory
WORKDIR /usr/src/app
# Copy dependency definitions first for better Docker caching
COPY package.json /usr/src/app
# Install app dependencies
RUN npm install
# Copy the entire application code
COPY . /usr/src/app
# My app binds to port NODE_PORT; use the EXPOSE instruction for Docker daemon mapping:
EXPOSE ${NODE_PORT}
CMD npm run dev
These changes ensure consistency and readability.
Signed-off-by: Thoshinny B <69354714+Thoshinny-cyber@users.noreply.github.com>
|
||
|---|---|---|
| .. | ||
| config | ||
| db | ||
| logs | ||
| models/todos | ||
| routes | ||
| utils/helpers | ||
| .dockerignore | ||
| Dockerfile | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| server.js | ||
Snippet of backend(Node.js)DockerFile
You will find this DockerFile file in the root directory of the project.
FROM node:13.13.0-stretch-slim
#Argument that is passed from docker-compose.yaml file
ARG NODE_PORT
#Echo the argument to check passed argument loaded here correctly
RUN echo "Argument port is : $NODE_PORT"
# Create app directory
WORKDIR /usr/src/app
# Copy dependency definitions
COPY package.json /usr/src/app
# Install app dependencies
RUN npm install
# Get all the code needed to run the app
COPY . /usr/src/app
#In my case my app binds to port NODE_PORT so you'll use the EXPOSE instruction to have it mapped by the docker daemon:
EXPOSE ${NODE_PORT}
CMD npm run dev
Explanation of backend(Node.js) DockerFile
-
The first line tells Docker to use another Node image from the DockerHub. We’re using the official Docker image for Node.js and it’s version 10 image.
-
On second line we declare argument
NODE_PORTwhich we will pass it fromdocker-compose. -
On third line we log to check argument is successfully read
-
On fourth line we set a working directory ,where the app code will be set to present inside the Docker container.
-
On fifth line, we are copying our dependency file (i,e package.json) into container working directory which was set on line four.
-
On sixth line, we run npm install for dependencies installation in container.
-
On line seven, we are copying/bundling our code working directory into container working directory which was set on line four.
-
On Line eight, we setup the port, that Docker will expose when the container is running. In our case it is the port which we define inside
.envfile, read it fromdocker-composethen passed as a argument to the (backend)DockerFile. -
And at last, we tell docker to execute our app inside the container by using node to run `npm run dev. It is the command which I registered in package.json in script section.